Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Buffer serialization and deserialization tests #263

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Add Buffer serialization and deserialization tests #263

merged 1 commit into from
Jan 15, 2024

Conversation

mickvangelderen
Copy link

Also considering serialized data from previous versions.

@mickvangelderen
Add Buffer serialization and deserialization tests
cc6118e 
Also considering serialized data from previous versions.
@mickvangelderen mickvangelderen mentioned this pull request Jan 12, 2024
Closed
@mickvangelderen
Copy link
Author

There is an opportunity to compress the serialized form of Owned(Vec::default()) from 12 bytes (4 byte variant + 8 byte length) to 4 bytes (4 byte variant of the now removed empty variant) here cc6118e#diff-713b6594ea19910835658a7f7c5dfd3677a3528c932475c8ac342bfd78473c2dR155-R158.

@mickvangelderen mickvangelderen merged commit ea0d657 into develop Jan 15, 2024
4 checks passed
@mickvangelderen mickvangelderen deleted the add-buffer-serialization-tests branch January 15, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreisilviudragnea andreisilviudragnea andreisilviudragnea approved these changes

@anton-lisanin anton-lisanin Awaiting requested review from anton-lisanin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mickvangelderen @andreisilviudragnea