Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NDEV-2514: Refactor get_config module #255

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

andreisilviudragnea
Copy link

@andreisilviudragnea andreisilviudragnea commented Jan 11, 2024

  • Moved all code related to retrieving chain configuration into get_config module.
  • Added more object orientation, by adding the program_id: Pubkey to ConfigSimulator enum variants and converting most functions to methods on ConfigSimulator enum.
  • Isolated ProgramTestContext retrieval from PROGRAM_TEST_CONTEXT static variable inside program_test_context function, so it can be easier changed to a new ProgramTestContext for each request model during testing.
  • A few renames to make it clear the difference between simulate_evm_instruction vs simulate_solana_instruction.
  • Removed some unused code.

@anton-lisanin
Copy link
Collaborator

@s-medvedev please check if this conflicts with your interoperability plans.

Deniskore
Deniskore previously approved these changes Jan 15, 2024
Copy link

@Deniskore Deniskore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objections 👍🏼

@andreisilviudragnea andreisilviudragnea merged commit 7e70f95 into develop Jan 16, 2024
4 checks passed
@andreisilviudragnea andreisilviudragnea deleted the NDEV-2514-refactor-get-config branch January 16, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants