forked from neonevm/neon-evm
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NDEV-2514: Refactor get_config module #255
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@s-medvedev please check if this conflicts with your interoperability plans. |
d1b4e2a
to
3f148c7
Compare
stanislav-tkach
previously approved these changes
Jan 15, 2024
Deniskore
previously approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no objections 👍🏼
9d6f265
stanislav-tkach
approved these changes
Jan 15, 2024
Deniskore
approved these changes
Jan 15, 2024
anton-lisanin
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_config
module.program_id: Pubkey
toConfigSimulator
enum variants and converting most functions to methods onConfigSimulator
enum.ProgramTestContext
retrieval fromPROGRAM_TEST_CONTEXT
static variable insideprogram_test_context
function, so it can be easier changed to a newProgramTestContext
for each request model during testing.simulate_evm_instruction
vssimulate_solana_instruction
.