Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: automated rename of Tenant -> TenantShard #10428

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jcsp
Copy link
Collaborator

@jcsp jcsp commented Jan 16, 2025

Problem

This has been a pending cleanup since we added sharding.

Historically, Tenant represented a whole tenant, but these days it only represents one shard of a tenant. This is confusing for any first-time reader of the codebase.

Summary of changes

  • Rename Tenant -> TenantShard
  • Rename TenantManager -> TenantShardManager
  • Rename a couple of helper types (TenantsMap, TenantHarness)

This isn't totally comprehensive, but addresses the most intrusive piece of confusing naming (the Tenant type not representing a whole tenant).

@jcsp jcsp requested a review from problame January 16, 2025 15:45
@jcsp jcsp added c/storage/pageserver Component: storage: pageserver a/tech_debt Area: related to tech debt labels Jan 16, 2025
Copy link

7326 tests run: 6948 passed, 0 failed, 378 skipped (full report)


Flaky tests (2)

Postgres 17

Postgres 16

  • test_physical_replication_config_mismatch_max_locks_per_transaction: release-arm64

Code coverage* (full report)

  • functions: 33.7% (8425 of 25029 functions)
  • lines: 49.2% (70500 of 143376 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
652479c at 2025-01-16T16:46:02.875Z :recycle:

@jcsp jcsp marked this pull request as ready for review January 16, 2025 16:56
@jcsp jcsp requested a review from a team as a code owner January 16, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt c/storage/pageserver Component: storage: pageserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant