Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: use multiple AZs by default #10421

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

tests: use multiple AZs by default #10421

wants to merge 4 commits into from

Conversation

jcsp
Copy link
Collaborator

@jcsp jcsp commented Jan 16, 2025

Problem

To prevent repeats of #10420, a more robust default is to use multiple AZs when using multiple pageservers. This is also more realistic.

Summary of changes

  • Set NeonEnvBuilder.num_azs to 3 by default
  • Set num_azs=1 explicitly in tests that rely on that (i.e. tests that create multiple pageservers and expect a sharded tenant to use all of them).

@jcsp jcsp added a/test Area: related to testing a/tech_debt Area: related to tech debt labels Jan 16, 2025
@github-actions GitHub Actions
Copy link

6660 tests run: 6271 passed, 55 failed, 334 skipped (full report)

Failures on Postgres 17

Failures on Postgres 16

Failures on Postgres 15

Failures on Postgres 14

# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_change_pageserver[release-pg14] or test_readonly_node_gc[release-pg14] or test_timeline_detach_ancestor_interrupted_by_deletion[release-pg14-delete_timeline-True] or test_retryable_500_hit_through_storcon_during_timeline_detach_ancestor[release-pg14] or test_gc_blocking_by_timeline[release-pg14-True] or test_change_pageserver[release-pg15] or test_change_pageserver[release-pg15] or test_readonly_node_gc[release-pg15] or test_readonly_node_gc[release-pg15] or test_timeline_detach_ancestor_interrupted_by_deletion[release-pg15-delete_timeline-True] or test_timeline_detach_ancestor_interrupted_by_deletion[release-pg15-delete_timeline-True] or test_retryable_500_hit_through_storcon_during_timeline_detach_ancestor[release-pg15] or test_retryable_500_hit_through_storcon_during_timeline_detach_ancestor[release-pg15] or test_gc_blocking_by_timeline[release-pg15-True] or test_gc_blocking_by_timeline[release-pg15-True] or test_change_pageserver[release-pg16] or test_change_pageserver[release-pg16] or test_readonly_node_gc[release-pg16] or test_readonly_node_gc[release-pg16] or test_timeline_detach_ancestor_interrupted_by_deletion[release-pg16-delete_timeline-True] or test_timeline_detach_ancestor_interrupted_by_deletion[release-pg16-delete_timeline-True] or test_retryable_500_hit_through_storcon_during_timeline_detach_ancestor[release-pg16] or test_retryable_500_hit_through_storcon_during_timeline_detach_ancestor[release-pg16] or test_gc_blocking_by_timeline[release-pg16-True] or test_gc_blocking_by_timeline[release-pg16-True] or test_change_pageserver[release-pg17] or test_change_pageserver[release-pg17] or test_change_pageserver[debug-pg17] or test_change_pageserver[release-pg17] or test_change_pageserver[release-pg17] or test_readonly_node_gc[release-pg17] or test_readonly_node_gc[release-pg17] or test_readonly_node_gc[debug-pg17] or test_readonly_node_gc[release-pg17] or test_readonly_node_gc[release-pg17] or test_shard_preferred_azs[release-pg17] or test_shard_preferred_azs[release-pg17] or test_shard_preferred_azs[debug-pg17] or test_shard_preferred_azs[release-pg17] or test_shard_preferred_azs[release-pg17] or test_timeline_detach_ancestor_interrupted_by_deletion[release-pg17-delete_timeline-True] or test_timeline_detach_ancestor_interrupted_by_deletion[release-pg17-delete_timeline-True] or test_timeline_detach_ancestor_interrupted_by_deletion[release-pg17-delete_timeline-True] or test_timeline_detach_ancestor_interrupted_by_deletion[release-pg17-delete_timeline-True] or test_timeline_detach_ancestor_interrupted_by_deletion[debug-pg17-delete_timeline-True] or test_retryable_500_hit_through_storcon_during_timeline_detach_ancestor[release-pg17] or test_retryable_500_hit_through_storcon_during_timeline_detach_ancestor[release-pg17] or test_retryable_500_hit_through_storcon_during_timeline_detach_ancestor[release-pg17] or test_retryable_500_hit_through_storcon_during_timeline_detach_ancestor[release-pg17] or test_retryable_500_hit_through_storcon_during_timeline_detach_ancestor[debug-pg17] or test_gc_blocking_by_timeline[release-pg17-True] or test_gc_blocking_by_timeline[release-pg17-True] or test_gc_blocking_by_timeline[release-pg17-True] or test_gc_blocking_by_timeline[release-pg17-True] or test_gc_blocking_by_timeline[debug-pg17-True]"
Flaky tests (4)

Postgres 17

Postgres 15

  • test_storage_controller_smoke[combination_nnnnn]: release-arm64

Test coverage report is not available

The comment gets automatically updated with the latest test results
6acc2cf at 2025-01-16T10:56:43.676Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
a/tech_debt Area: related to tech debt a/test Area: related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jcsp