tests: make reconcile_until_idle more aggressive by default #10419
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
reconcile_until_idle
helper backs off when the controller appears to be busy. However, this leads to long runtimes when there are multiple optimisations pending, for example after a shard split. The #9916 changes made migrations take extra steps in some cases (creating temporary secondary locations), which highlights runtime impact of reconcile_until_idle.Example failure of test_timeline_ancestor_detach_idempotent_success where reconcile had backed off to 5s period
https://neon-github-public-dev.s3.amazonaws.com/reports/pr-10411/12794755547/index.html#/testresult/47e461aab29cdf4b
Summary of changes