Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

page_service: unit-test batching logic #9834

Open
Tracked by #9377
problame opened this issue Nov 21, 2024 · 0 comments
Open
Tracked by #9377

page_service: unit-test batching logic #9834

problame opened this issue Nov 21, 2024 · 0 comments

Comments

@problame
Copy link
Contributor

problame commented Nov 21, 2024

          It would be really nice if we could unit test this batching logic (doesn't have to happen in this PR - gone over it enough times to be certain there's nothing obvious). `self` usage isn't too bad here, but we would need to hide `PostgressBackend` behind an interface where we can mock `read_message`. Something like that would be useful in other places too.

Originally posted by @VladLazar in #9792 (comment)


Consider extracting the merging condition check into a function that can be unit-tested

#9851 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant