Merge branch 'feature/password-rotation' of github.com:StephenCathcar…

…t/neo4j-go-driver into feature/password-rotation

neo4j/internal/pool/pool.go

@@ -452,8 +452,7 @@ func (p *Pool) Return(ctx context.Context, c idb.Connection) {
 }
 
 func (p *Pool) OnNeo4jError(ctx context.Context, connection idb.Connection, error *db.Neo4jError) error {
-	switch error.Code {
-	case "Neo.ClientError.Security.AuthorizationExpired":
+	if error.Code == "Neo.ClientError.Security.AuthorizationExpired" {
 		serverName := connection.ServerName()
 		p.serversMut.Lock()
 		defer p.serversMut.Unlock()
@@ -473,16 +472,16 @@ func (p *Pool) OnNeo4jError(ctx context.Context, connection idb.Connection, erro
 				error.MarkRetriable()
 			}
 		}
-	case "Neo.TransientError.General.DatabaseUnavailable":
+	}
+	if error.Code == "Neo.TransientError.General.DatabaseUnavailable" {
 		p.deactivate(ctx, connection.ServerName())
-	default:
-		if error.IsRetriableCluster() {
-			var database string
-			if dbSelector, ok := connection.(idb.DatabaseSelector); ok {
-				database = dbSelector.Database()
-			}
-			p.deactivateWriter(connection.ServerName(), database)
+	}
+	if error.IsRetriableCluster() {
+		var database string
+		if dbSelector, ok := connection.(idb.DatabaseSelector); ok {
+			database = dbSelector.Database()
 		}
+		p.deactivateWriter(connection.ServerName(), database)
 	}
 
 	return nil

testkit-backend/backend.go

@@ -1106,7 +1106,8 @@ func (b *backend) handleRequest(req map[string]any) {
 				//"Feature:API:Liveness.Check",
 				"Feature:API:Result.List",
 				"Feature:API:Result.Peek",
-				"Feature:API:RetryableExceptions",
+				//"Feature:API:Result.Single",
+				//"Feature:API:Result.SingleOptional",
 				"Feature:API:Session:AuthConfig",
 				//"Feature:API:Session:NotificationsConfig",
 				//"Feature:API:SSLConfig",