Avoiding throw AggregateException #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenlineo
force-pushed
the
1.5-remove-AggregateException
branch
3 times, most recently
from
22138b1 to
9bc6939
Compare
ali-ince
requested changes
Aug 14, 2017
| @@ -62,7 +62,7 @@ private void Retry(int index, IRetryLogic retryLogic) | |||
| })); | |||
| timer.Stop(); | |||
|
|
|||
| var error = e as AggregateException; | |||
| var error = e.InnerException as AggregateException; | |||
There was a problem hiding this comment.
We shall also check for e's type against ServiceUnavailableException.
| @@ -46,11 +46,12 @@ public void ShouldRetry() | |||
| })); | |||
| timer.Stop(); | |||
|
|
|||
| var error = e as AggregateException; | |||
| var error = e.InnerException as AggregateException; | |||
There was a problem hiding this comment.
We shall also check for e's type against ServiceUnavailableException.
zhenlineo
force-pushed
the
1.5-remove-AggregateException
branch
from
9bc6939 to
324f7f7
Compare
|
@ali-ince Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made Retry and TcpClient to not throw AggregatedException on the top level.
But as Retry and TcpClient still try to do some work for several times, the inner errors as a list are still stored in a AggregatedException.