Routing driver #115
Merged
Routing driver #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 7, 2016 17:43
Created ClusterConnectionPool as pool of existing connection pools
Added RoutingDriver for `bolt+routing` scheme. Added the basic logic of `CheckServers` TODO: Discovery, multithread support, error handling
Added a load balancer who has the full control of a cluster view and a cluster connection pool Added discovery manager who takes a connection and perform discovery to save the new cluster status for creating a new cluster view What is missing now: timeout, error handling, remove connection when session/tx throw connection errors
zhenlineo
force-pushed
the
1.1-discovery-and-routing
branch
3 times, most recently
from
a988244 to
d06a6ab
Compare
zhenlineo
force-pushed
the
1.1-discovery-and-routing
branch
from
d06a6ab to
d143b54
Compare
added 2 commits
October 27, 2016 16:46
Built a `MockedMessagingClient` to verify messages sent via driver and to simulate messages from the server for tests
Added tests to verify error handlers are added correctly Fixed the bug where the error handlers are added after client.start and init.
zhenlineo
force-pushed
the
1.1-discovery-and-routing
branch
from
fd97a8b to
898dea3
Compare
lutovich
reviewed
Nov 4, 2016
| { | ||
| private const int MinRouterCount = 1; | ||
| private readonly ConcurrentRoundRobinSet<Uri> _routers = new ConcurrentRoundRobinSet<Uri>(); | ||
| private readonly ConcurrentRoundRobinSet<Uri> _detachedRouters = new ConcurrentRoundRobinSet<Uri>(); |
There was a problem hiding this comment.
Uris are only added to this set, otherwise it is never used. We need to decide if _detachedRouters is needed.
|
|
||
| public static bool IsClusterError(this Neo4jException error) | ||
| { | ||
| return error.Code.Equals("Neo.ClientError.Cluster.NotALeader") |
There was a problem hiding this comment.
Would be nice to have constants or helper methods for these strings Neo.ClientError.Cluster.NotALeader and Neo.ClientError.General.ForbiddenOnReadOnlyDatabase. They are used here in Neo4jErrorExtensions and in RoundRobinLoadBalancer.
|
|
||
| if (uri.Port == -1) | ||
| { | ||
| var builder = new UriBuilder(uri.Scheme, uri.Host, 7687); |
There was a problem hiding this comment.
Maybe let's introduce a constant for 7687
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created
ClusterConnectionPoolas pool of existing connection pools.Added new scheme
bolt+routingfor creating a newRoutingDriverfor routing queries to a cluster.RoutingDriverholds aLoadbalancerwhich is responsible for supplying an usable connection during the creation of a specific read/write session.Loadbalancerholds aClusterViewwhich describes the client's current understanding of the servers in the cluster and aClusterConnectionPoolthat maintains a dictionary of {server, connection pool}.ClusterViewmight become unavailable and get (temporarily or permanently) removed. TheClusterConnectionPoolcould choose to either still keep the connection pool of a unavailable server or remove it totally too. However it is illegal to have servers that are known toClusterViewbut have no connection pool entry inClusterConnectionPool.ClusterViewload balance the connections to the servers using aConcurrentRoundRobinSet.Added error handling callback in
SocketConnection.SocketConnectiontoPooledConnectionLoadbalanceris done via a error handling event callback inSocketConnectionpassed byLoadBalancer.TODO:
Feature: Retry rediscovery?
ITs