feat: add support for 5.15 key format and rename relationship keys #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-ince
reviewed
Dec 6, 2023
Comment on lines
113
to
125
| private static List<Map<String, Object>> getKeys(Map<String, Object> cypherMap) { | ||
| var keysList = ModelUtils.getList(cypherMap, "keys", Map.class); | ||
| if (keysList != null) { | ||
| return ModelUtils.coerceToListOfMaps(keysList, String.class, Object.class); | ||
| } | ||
|
|
||
| // Check if the key structure is pre Neo4j 5.15 | ||
| var keyMap = ModelUtils.getMap(cypherMap, "key", String.class, Object.class); | ||
| if (keyMap == null) { | ||
| return null; | ||
| } | ||
| return List.of(keyMap); | ||
| } |
There was a problem hiding this comment.
just a nit but should this also move into ModelUtils?
|
|
||
| /** | ||
| * Neo4j 5.15+ introduced a breaking change in node ande relationship keys structure. This suite verifies if | ||
| * CLC Client is backward compatible with 5.14 and earlier. |
There was a problem hiding this comment.
Suggested change
| * CLC Client is backward compatible with 5.14 and earlier. | |
| * CDC Client is backward compatible with 5.14 and earlier. |
| "Person", | ||
| List.of(Map.of("id", 1L), Map.of("name", "John")), | ||
| "Employee", | ||
| List.of(Map.of("id", 5L, "role", "manager"))), |
There was a problem hiding this comment.
just looking into these now, having both id: 1L and id: 5L for the same property on the same node doesn't make sense at all. Do you mind updating these to match?
ali-ince
reviewed
Dec 6, 2023
| * TODO At the moment of writing Neo4j 5.15 hasn't publicly releases yet. This means that these tests are identical to | ||
| * {@link CDCClient514IT Integration tests for Neo4j 5.14}. When 5.15 is released, we need to enabled these tests. | ||
| */ | ||
| @Disabled |
There was a problem hiding this comment.
maybe just add a card for this in Next column on the board so that we don't forget?
There was a problem hiding this comment.
Chicken-egg dilemma. Was going to do this after the approval. Here is the card https://trello.com/c/Qor9KTa7/387-enable-integration-test-for-neo4j-515-in-cdc-client-lib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keysfrom result depending on value type in key map.keysandkeyand pick the data structure from there.