-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated subscriptions #5662
Conversation
🦋 Changeset detectedLatest commit: 74dfb4b The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2daba97
to
98e04db
Compare
147eb3d
to
98e04db
Compare
6632d95
to
3deeea3
Compare
3deeea3
to
02124cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good, but I do think we should maybe re-discuss the API here?
subscriptions: new Neo4jGraphQLSubscriptionsCDCEngine({ | ||
driver, | ||
}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think let's leave this like this like now for this PR, but after seeing this and the fact that literally the only thing that can be passed in is the CDC engine, I'm definitely camp "this should be turned into an object for configuration" - maybe a follow-up PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one advantage of this is that it leaves the door open for capturing the events by extending this class, I know it is not the primary use case, but some users have been using the CDC subscriptions to capture these events for some external processing.
Co-authored-by: Darrell Warde <[email protected]>
Description
Removes support for non-cdc subscriptions. This means the only available engine for subscriptions is
Neo4jGraphQLSubscriptionsCDCEngine
:The default behaviour of subscriptions has also been updated to use CDC, so now passing
true
will use the CDC engine with the default parameters and driver:Remove support for relationship subscriptions:
*RelationshipCreated
*RelatiosnhipDeleted