Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aggregation filters that are not aggregation filters #5639

Merged

Conversation

darrellwarde
Copy link
Contributor

Description

Remove aggregation filters that are not aggregation filters. These were deprecated in 5.x.

Complexity

Complexity: Medium

Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: f7f1125

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@neo4j/graphql Major
@neo4j/graphql-ogm Major
@neo4j/graphql-amqp-subscriptions-engine Major
neo-place Patch
apollo-subscriptions-server Patch
yoga-subscriptions-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@MacondoExpress MacondoExpress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the setting aggregationFilters in excludeDeprecatedFields is still present in the file src/types/index.ts

@darrellwarde
Copy link
Contributor Author

the setting aggregationFilters in excludeDeprecatedFields is still present in the file src/types/index.ts

Correct me if I'm wrong, but this one is still used for the aggregation filters without LENGTH that need removing. 🙂

@darrellwarde darrellwarde merged commit 4438b60 into neo4j:6.x Oct 9, 2024
46 checks passed
@MacondoExpress
Copy link
Contributor

the setting aggregationFilters in excludeDeprecatedFields is still present in the file src/types/index.ts

Correct me if I'm wrong, but this one is still used for the aggregation filters without LENGTH that need removing. 🙂

You're absolutely right, forgot about these!

This was referenced Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants