Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/5066 #5072

Merged
merged 2 commits into from
May 7, 2024
Merged

Fix/5066 #5072

merged 2 commits into from
May 7, 2024

Conversation

angrykoala
Copy link
Member

Description

This PR fixes authorization for unions in which some variables where missing

@angrykoala angrykoala requested a review from a-alle May 3, 2024 12:37
@angrykoala angrykoala linked an issue May 3, 2024 that may be closed by this pull request
Copy link

changeset-bot bot commented May 3, 2024

🦋 Changeset detected

Latest commit: aec402e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@neo4j/graphql Patch
@neo4j/graphql-ogm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@neo4j-team-graphql
Copy link
Collaborator

Performance Report

No Performance Changes

Show Full Table
name dbHits old dbHits time (ms) old time (ms) maxRows
aggregations.TopLevelAggregate 3404 3404 32 50 1134
aggregations.TopLevelAggregateWithMultipleFields 6802 6802 44 61 1134
aggregations.NestedAggregation 16544 16544 58 84 2174
aggregations.AggregationWithWhere 11970 11970 65 61 2174
aggregations.AggregationWhereWithinNestedRelationships 22116478 22116478 2205 2469 2008534
aggregations.AggregationWhereWithinNestedConnections 22116478 22116478 2167 2323 2008534
aggregations.NestedCountFromMovieToActors 9701 9701 30 40 2174
aggregations.NestedCountFromActorsToMovie 9928 9928 31 38 2174
aggregations.DeeplyNestedCount 11062184 11062184 2107 2915 2008534
aggregations.InterfacesAggregations 6242 6242 42 77 2080
aggregations.InterfacesAggregationsWithTwoFields 11444 11444 70 142 2080
batch-create.BatchCreate 4200 4200 125 175 600
batch-create.BatchCreateSmall 77 77 53 61 11
connect.createAndConnect 14424 14424 141 166 3003
connections.Connection 14049 14049 58 75 2174
connections.NestedConnection 41068 41068 126 136 4516
create.SimpleMutation 7 7 50 53 1
cypher-directive.TopLevelMutationDirective 1135 1135 23 27 1134
delete.SimpleDelete 19401 19401 183 231 1040
delete.NestedDeleteInUpdate 19165 19165 115 151 1183
2871.NestedRelationshipFilter 23041 23122 54 64 4422
2925.SingleRelationshipFilter 6468 6468 34 45 1040
2925.NestedSingleRelationshipFilter 22891 22891 67 111 2174
2925.SingleRelationshipRequiredFilter 5201 5201 35 43 1040
2925.NestedSingleRelationshipRequiredFilter 9361 9361 53 72 1040
query.SimpleQuery 3121 3121 18 24 1040
query.SimpleQueryWithRelationship 16129 16129 37 61 2174
query.QueryWhere 9680 9661 33 46 2163
query.SimpleQueryWithNestedWhere 9847 9828 47 64 2163
query.Nested 10095502 10095502 6968 6609 2008534
query.NestedWithFilter 10074351 10074351 6934 6713 2004000
query.OrFilterOnRelationships 42453 43230 139 154 1695
query.OrFilterOnRelationshipsAndNested 36134 37564 184 206 1695
query.QueryWithNestedIn 13172 13587 47 55 1151
query.NestedConnectionWhere 9801 9801 47 80 2174
query.DeeplyNestedConnectionWhere 9905 9986 64 84 2174
query.DeeplyNestedWithRelationshipFilters 18848 18962 114 136 1614
query.NestedWithRelationshipSingleFilters 3865 3865 135 178 1134
query.Fulltext 64 64 29 33 16
query.FulltextWithNestedQuery 558 558 38 55 84
sorting-and-cypher.TopLevelSortWithCypher 14059 14059 37 41 2174
sorting-and-cypher.TopLevelConnectionSortWithCypher 14059 14059 56 73 2174
sorting-and-cypher.TopLevelSortWithCypherWithNested 14204 14204 51 57 2174
sorting-and-cypher.TopLevelConnectionSortWithCypherWithNested 14204 14204 95 105 2174
sorting-and-cypher.TopLevelSortWithExpensiveCypher 14933 14929 101 108 2174
sorting-and-cypher.TopLevelConnectionSortWithExpensiveCypher 14404 14404 101 120 2174
sorting.SortMultipleTypes 3498 3498 80 94 1040
sorting.SortMultipleTypesWithCypherWithCypher 14504 14504 104 112 2174
sorting.SortOnNestedFields 14049 14049 40 49 2174
sorting.SortDeeplyNestedFields 43148 43148 75 104 4516
sorting.ConnectionWithSort 3281 3281 75 75 1040
unions.SimpleUnionQuery 321 321 51 71 35
unions.SimpleUnionQueryWithMissingFields 293 293 51 70 35
unions.NestedUnion 410637 410637 252 296 33033
unions.NestedUnionWithMissingFields 384611 384611 227 251 33033
update.NestedUpdate 16143 16143 101 108 2002

Old Schema Generation: 27.404s
Schema Generation: 27.451s
Old Subgraph Schema Generation: 31.767s
Subgraph Schema Generation: 31.889s

@angrykoala angrykoala merged commit 4c09310 into dev May 7, 2024
83 checks passed
@angrykoala angrykoala deleted the fix/5066 branch May 7, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Pull requests
Development

Successfully merging this pull request may close these issues.

Neo4jError: Variable not defined caused by authorization filters
3 participants