Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-existing relationships for 1 to 1 relationship. #4762

Merged
merged 6 commits into from
Feb 26, 2024

Conversation

MacondoExpress
Copy link
Contributor

Description

Keep supporting legacy behavior of passing null as a relationship filter argument.
The legacy null behavior is to use the null argument to generate a relationship filter, that filters a node if the relationship target is present in the database.

Closes: #4667

Copy link

changeset-bot bot commented Feb 23, 2024

🦋 Changeset detected

Latest commit: fa4cab1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@neo4j/graphql Patch
@neo4j/graphql-toolbox Patch
@neo4j/graphql-ogm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Feb 23, 2024

Thanks for the Neo4j GraphQL Toolbox updates.

The Neo4j GraphQL Toolbox has now been torn down - reopening this PR will republish it.

@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Feb 23, 2024

Performance Report

No Performance Changes

Show Full Table
name dbHits old dbHits time (ms) old time (ms) maxRows
aggregations.TopLevelAggregate 3404 3404 35 42 1134
aggregations.TopLevelAggregateWithMultipleFields 6802 6802 46 56 1134
aggregations.NestedAggregation 16544 16544 56 74 2174
aggregations.AggregationWithWhere 11970 11970 40 59 2174
aggregations.AggregationWhereWithinNestedRelationships 22116478 22116478 2167 2330 2008534
aggregations.AggregationWhereWithinNestedConnections 22116478 22116478 2210 2303 2008534
aggregations.NestedCountFromMovieToActors 9701 9701 37 37 2174
aggregations.NestedCountFromActorsToMovie 9928 9928 36 44 2174
aggregations.DeeplyNestedCount 11062184 11062184 2931 3025 2008534
aggregations.InterfacesAggregations 6242 6242 41 55 2080
aggregations.InterfacesAggregationsWithTwoFields 11444 11444 68 221 2080
batch-create.BatchCreate 4200 4200 123 159 600
batch-create.BatchCreateSmall 77 77 88 66 11
connect.createAndConnect 14424 14424 170 268 3003
connections.Connection 14049 14049 79 135 2174
connections.NestedConnection 41068 41068 119 183 4516
create.SimpleMutation 7 7 54 62 1
cypher-directive.TopLevelMutationDirective 1135 1135 56 24 1134
delete.SimpleDelete 19401 19401 239 201 1040
delete.NestedDeleteInUpdate 19165 19165 178 238 1179
2871.NestedRelationshipFilter 23081 23172 85 65 4436
2925.SingleRelationshipFilter 6468 6468 44 40 1040
2925.NestedSingleRelationshipFilter 22891 22891 72 84 2174
2925.SingleRelationshipRequiredFilter 5201 5201 34 42 1040
2925.NestedSingleRelationshipRequiredFilter 9361 9361 48 67 1040
query.SimpleQuery 3121 3121 20 27 1040
query.SimpleQueryWithRelationship 16129 16129 34 42 2174
query.QueryWhere 9683 9691 35 37 2164
query.SimpleQueryWithNestedWhere 9850 9858 44 51 2164
query.Nested 10095502 10095502 7125 7055 2008534
query.NestedWithFilter 10074351 10074351 6957 6969 2004000
query.OrFilterOnRelationships 42609 41706 152 178 1672
query.OrFilterOnRelationshipsAndNested 35877 35176 179 226 1672
query.QueryWithNestedIn 13639 13955 51 55 1308
query.NestedConnectionWhere 9801 9801 47 57 2174
query.DeeplyNestedConnectionWhere 9860 9915 63 92 2174
query.DeeplyNestedWithRelationshipFilters 18800 18812 135 162 1598
query.NestedWithRelationshipSingleFilters 3865 3865 152 186 1134
query.Fulltext 64 64 27 40 16
query.FulltextWithNestedQuery 558 558 38 44 84
sorting-and-cypher.TopLevelSortWithCypher 14059 14059 45 47 2174
sorting-and-cypher.TopLevelConnectionSortWithCypher 14059 14059 72 76 2174
sorting-and-cypher.TopLevelSortWithCypherWithNested 14155 14189 57 62 2174
sorting-and-cypher.TopLevelConnectionSortWithCypherWithNested 14155 14189 96 107 2174
sorting-and-cypher.TopLevelSortWithExpensiveCypher 14592 14425 94 117 2174
sorting-and-cypher.TopLevelConnectionSortWithExpensiveCypher 14437 14355 96 114 2174
sorting.SortMultipleTypes 3498 3498 77 89 1040
sorting.SortMultipleTypesWithCypherWithCypher 14532 14455 106 122 2174
sorting.SortOnNestedFields 14049 14049 54 57 2174
sorting.SortDeeplyNestedFields 43148 43148 72 109 4516
sorting.ConnectionWithSort 3281 3281 75 90 1040
unions.SimpleUnionQuery 321 321 51 60 35
unions.SimpleUnionQueryWithMissingFields 293 293 50 64 35
unions.NestedUnion 410637 410637 265 263 33033
unions.NestedUnionWithMissingFields 384611 384611 299 260 33033
update.NestedUpdate 16143 16143 115 116 2002

Old Schema Generation: 26.375s
Schema Generation: 26.043s
Old Subgraph Schema Generation: 30.459s
Subgraph Schema Generation: 29.667s

@MacondoExpress MacondoExpress merged commit 714b4ed into neo4j:dev Feb 26, 2024
83 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Pull requests
Development

Successfully merging this pull request may close these issues.

Filtering for non existing relationships does not work
3 participants