Move interface projection to cypher builder #2030
Conversation
|
…ion-to-cypher-builder
|
Thanks for the UI updates. The UI has now been torn down - reopening this PR will republish it. |
angrykoala
requested review from
mjfwebb,
tbwiss,
MacondoExpress and
darrellwarde
angrykoala
force-pushed
the
move-interface-projection-to-cypher-builder
branch
from
c820d7a
to
7e0baa2
Compare
angrykoala
force-pushed
the
move-interface-projection-to-cypher-builder
branch
from
7e0baa2
to
42f3075
Compare
| MATCH (this)-[:ACTED_IN]->(this_Series:Series) | ||
| CALL apoc.util.validate(NOT ((this_Series.episodes IS NOT NULL AND this_Series.episodes = $this_Seriesauth_param0)), \\"@neo4j/graphql/FORBIDDEN\\", [0]) | ||
| MATCH (this)-[thisthis1:ACTED_IN]->(this_Series:\`Series\`) | ||
| WHERE apoc.util.validatePredicate(NOT ((this_Series.episodes IS NOT NULL AND this_Series.episodes = $thisparam0)), \\"@neo4j/graphql/FORBIDDEN\\", [0]) |
There was a problem hiding this comment.
Yeah this is super slick, I love it! 👏
|
|
||
| function createInterfaceProjectionAndParams({ | ||
| export default function createInterfaceProjectionAndParams({ |
There was a problem hiding this comment.
Any reason for the default export? It feels to me like we're moving away from this direction in most cases.
There was a problem hiding this comment.
Oh, it is just because that was what were being exported, and to reduce the scope of the refactor I kept it as such
| MATCH (this)-[:HAS_CONTENT]->(this_Post:Post) | ||
| WHERE (exists((this_Post)<-[:HAS_CONTENT]-(:\`User\`)) AND all(auth_this0 IN [(this_Post)<-[:HAS_CONTENT]-(auth_this0:\`User\`) | auth_this0] WHERE (auth_this0.id IS NOT NULL AND auth_this0.id = $this_Postauth_param0))) | ||
| MATCH (this)-[thisthis1:HAS_CONTENT]->(this_Post:\`Post\`) | ||
| WHERE (exists((this_Post:\`Post\`)<-[:HAS_CONTENT]-(:\`User\`)) AND all(thisthis2 IN [(this_Post:\`Post\`)<-[:HAS_CONTENT]-(thisthis2:\`User\`) | thisthis2] WHERE (thisthis2.id IS NOT NULL AND thisthis2.id = $thisparam0))) |
There was a problem hiding this comment.
I know we're currently suffering from this bug with EXISTS, but I feel like we should shortly (or maybe even already) be in a position where we can move to using EXISTS clauses across the board! 🥳
Description
This PR refactors interface projections so they are generated with CypherBuilder. This allows to remove duplicate code regarding filtering