[d4rLFQqM] Align all export modes with quoting consistency #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gem-neo4j
commented
Oct 8, 2024
| @@ -84,10 +84,11 @@ public Stream<ExportProgressInfo> all( | |||
| { | |||
| stream = false :: BOOLEAN, | |||
| batchSize = 20000 :: INTEGER, | |||
| bulkImport = true :: BOOLEAN, | |||
| bulkImport = false :: BOOLEAN, | |||
There was a problem hiding this comment.
Note to reviewer, I didn't change the default, it was this signature that was wrong :)
gem-neo4j
force-pushed
the
dev_make_export_csv_consistent
branch
from
7397b42 to
73bc81b
Compare
hvub
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
I think that looks fine.
Somethings noticed in passing here:
private void preventBulkImport(ExportConfig config) {
if (config.isBulkImport()) {
throw new RuntimeException(
"You can use the `bulkImport` only with apoc.export.all and apoc.export.csv.graph");
}
}
shouldn't the exception message say apoc.export.csv.all instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bulkImport was set to true, the quoting option the user input no longer worked. This PR makes the quoting work again and makes sure the defaults align with how it works for streaming and when bulkImport is false.