[7hH8ZRTU] Add new regex matcher by group names #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gem-neo4j
force-pushed
the
dev_add_new_groupby_regex_matcher
branch
2 times, most recently
from
cbf76bb to
d059533
Compare
gem-neo4j
changed the title
gem-neo4j
force-pushed
the
dev_add_new_groupby_regex_matcher
branch
from
fc38fb1 to
c969993
Compare
JoelBergstrand
approved these changes
Aug 14, 2024
| @@ -532,6 +538,139 @@ public void testRegexGroups() { | |||
| }); | |||
| } | |||
|
|
|||
| @Test | |||
| public void singleGroupNyName() { | |||
There was a problem hiding this comment.
Suggested change
| public void singleGroupNyName() { | |
| public void singleGroupByName() { |
| } | ||
|
|
||
| @Test | ||
| public void multipleGroupsNyName() { |
There was a problem hiding this comment.
Suggested change
| public void multipleGroupsNyName() { | |
| public void multipleGroupsByName() { |
| } | ||
|
|
||
| @Test | ||
| public void groupNyNameWithMissingFirstGroup() { |
There was a problem hiding this comment.
Suggested change
| public void groupNyNameWithMissingFirstGroup() { | |
| public void groupByNameWithMissingFirstGroup() { |
| } | ||
|
|
||
| @Test | ||
| public void groupNyNameWithMissingSecondGroup() { |
There was a problem hiding this comment.
Suggested change
| public void groupNyNameWithMissingSecondGroup() { | |
| public void groupByNameWithMissingSecondGroup() { |
| } | ||
|
|
||
| @Test | ||
| public void groupNyNameNoMatches() { |
There was a problem hiding this comment.
Suggested change
| public void groupNyNameNoMatches() { | |
| public void groupByNameNoMatches() { |
| } | ||
|
|
||
| @Test | ||
| public void groupNyNameWithInvalidPattern1() { |
There was a problem hiding this comment.
Suggested change
| public void groupNyNameWithInvalidPattern1() { | |
| public void groupByNameWithInvalidPattern1() { |
| } | ||
|
|
||
| @Test | ||
| public void groupNyNameWithInvalidPattern2() { |
There was a problem hiding this comment.
Suggested change
| public void groupNyNameWithInvalidPattern2() { | |
| public void groupByNameWithInvalidPattern2() { |
| } | ||
|
|
||
| @Test | ||
| public void groupNyNameWithNoGroupNames() { |
There was a problem hiding this comment.
Suggested change
| public void groupNyNameWithNoGroupNames() { | |
| public void groupByNameWithNoGroupNames() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new function for a support case surrounding the ability to reference group names.
Docs: https://github.com/neo4j/docs-apoc/pull/312