[NOID] Fixes directory that should be non existing #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncordon
force-pushed
the
fix-random-folder
branch
from
635330e to
5e2ef0f
Compare
ncordon
changed the title
loveleif
approved these changes
Jan 24, 2024
| "file://" + directory.getAbsolutePath() + "//..//..//..//..//apoc/" + FILENAME; | ||
| private static final String case15 = | ||
| "file:///%252e%252e%252f%252e%252e%252f%252e%252e%252f%252e%252e%252f/apoc/" + FILENAME; | ||
| private static final String nonExistingDirectory = "__non-existing-dir__"; |
There was a problem hiding this comment.
We could use Files.createTempDirectory and then we don't have to worry about leaving stuff around on the host running the build.
There was a problem hiding this comment.
But it's not going to create the file. If we do create the directory (even if it's temporary) then the tests would fail. I could make the name random if you prefer
There was a problem hiding this comment.
Ahh, ok! I thought it would create some files there at some point. Because if it does we could do Files.createTempDirectory().resolve("non-existing") and have a non existing directory and be sure that those files will not remain on the host. But if we don't it doesn't matter. Feel free to merge!
ncordon
force-pushed
the
fix-random-folder
branch
from
5e2ef0f to
655254b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Changes the name of the directory
apocto"__non-existing-dir__"so we get more chances of that directory truly not existing.Why
Because in some internal build we have an existing
apocfolder which was making the tests not work because they expect that folder to not exist.