[5kItK998] Fix bug in triggers #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loveleif
force-pushed
the
fix-missing-trigger
branch
from
744cfc7 to
a0978bd
Compare
loveleif
commented
Oct 16, 2023
| @@ -95,28 +98,31 @@ public void checkEnabled() { | |||
| } | |||
|
|
|||
| private void updateCache() { | |||
| activeTriggers.clear(); | |||
There was a problem hiding this comment.
This was the problem, triggers were not run between this call and adding them all back later on.
ncordon
reviewed
Oct 20, 2023
| private final Log log; | ||
| private final GraphDatabaseService db; | ||
| private final DatabaseManagementService databaseManagementService; | ||
| private final ApocConfig apocConfig; | ||
| private final Pools pools; | ||
| private final JobScheduler jobScheduler; | ||
|
|
||
| private long lastUpdate; | ||
| private volatile long lastUpdate; |
There was a problem hiding this comment.
Why does this need to be thread safe?
There was a problem hiding this comment.
It can be set and read from multiple different threads at the same time (from scheduled thread and from procedures calling into here).
ncordon
approved these changes
Oct 20, 2023
loveleif
force-pushed
the
fix-missing-trigger
branch
2 times, most recently
from
6753951 to
d6ff118
Compare
Fix a bug where active triggers are not executed for all transactions.
loveleif
force-pushed
the
fix-missing-trigger
branch
from
9b20f04 to
0fa5810
Compare
This was referenced Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where active triggers are not executed.