[q5Vf4pi2] Fix broken GeoCode tests #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gem-neo4j
force-pushed
the
dev_fix_broken_geocode_tests
branch
from
795ef46 to
f729c91
Compare
Lojjs
approved these changes
Aug 17, 2023
| "_comment_2B": "The 'events' defined input data, and 'geocode' are mocked output results.", | ||
| "_comment_2C": "No real geocoding service is used, as a service is internally mocked to provide these results.", | ||
| "_comment_1A": "'events' and 'geocode' are used in SpatialTest testing procedures in more complex Cypher queries", | ||
| "_comment_1B": "The 'events' defined input data, and 'geocode' are mocked output results.", |
There was a problem hiding this comment.
Suggested change
| "_comment_1B": "The 'events' defined input data, and 'geocode' are mocked output results.", | |
| "_comment_1B": "The 'events' define input data, and 'geocode' are mocked output results.", |
There was a problem hiding this comment.
I know this is not really related, so fix if you like
Lojjs
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The count of returned results had changed, hence them starting to break. I found the tests very hard to read so I rewrote them as well to be easier to understand.