-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GGP-460: testing with @neo4j-labs/temp-dbs #148
base: main
Are you sure you want to change the base?
Conversation
c77b0d8
to
2c6a786
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there more context I can read about this proposed change?
I personally would prefer to stick to a single way of running acceptance tests for all the movies repositories here.
This is currently embodied by https://github.com/neo4j-examples/movies-harness/.
.circleci/config.yml
Outdated
@@ -0,0 +1,25 @@ | |||
version: 2.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be preferable to stick to GitHub Actions since it's already in place.
@fbiville the goal is to have an example of using tests using the semi-experimental https://github.com/neo4j-contrib/neo4j-temp-db - we can keep the "real" tests but have the other as an example for third parties to consider for their projects. |
b19a6c9
to
83651e4
Compare
temp-db only works with neo4j > 4.0 and can only create databased on enterprise version
aaa28ed
to
6d8c213
Compare
Proof of concept of using @neo4j-labs/temp-dbs for creating disposable databases for testing.
How to test:
npm install
npm run test