Remove stored map of Procedure Handlers #4278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gem-neo4j
force-pushed
the
dev_fix_for_procedure_handler
branch
from
9daa015 to
12bf776
Compare
gem-neo4j
force-pushed
the
dev_fix_for_procedure_handler
branch
from
280d6ca to
f202ebf
Compare
|
I gave a shot without the AvailabilityListener, but it seems to be necessary, unlike the other handlers. |
…cept for the -SNAPSHOT prefix This reverts commit c53f2c7.
vga91
force-pushed
the
dev_fix_for_procedure_handler
branch
from
438b694 to
5114bf4
Compare
gem-neo4j
added a commit
that referenced
this pull request
Dec 10, 2024
* Update to behave differently for APOC extended --------- Co-authored-by: vga91 <[email protected]>
gem-neo4j
added a commit
that referenced
this pull request
Dec 10, 2024
* Remove stored map of Procedure Handlers (#4278) Co-authored-by: vga91 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of storing a map of the custom procedure handler to reference as a listener, which can cause a memory leak, common has been updated to find listeners and then add them. This means we can remove the map.