Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NOID] Upgrades gradle version #3699

Merged
merged 18 commits into from
Oct 31, 2023
Merged

[NOID] Upgrades gradle version #3699

merged 18 commits into from
Oct 31, 2023

Conversation

ncordon
Copy link
Contributor

@ncordon ncordon commented Jul 27, 2023 •
edited
Loading

What

Upgrades gradle to latest 8.x version with:

./gradlew wrapper --gradle-version 8.4

Why

Because we were getting errors that seem to be a bug in previous 6.x versions:

Could not resolve all dependencies for configuration ':core:testCompileClasspath'.
Problems reading data from Binary store in /private/var/folders/w1/990bdn7j5nb37bbydkqct5gh0000gn/T/gradle12884335207698123056.bin offset 28067 exists? true

@ncordon ncordon added team-cypher-surface Cypher Surface team should review the PR 4.4 labels Jul 27, 2023
gem-neo4j
gem-neo4j approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@gem-neo4j gem-neo4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :D

@ncordon ncordon force-pushed the 4.4-upgrade-gradle branch from 0646a23 to bd4bc5a Compare August 8, 2023 12:49
@ncordon ncordon force-pushed the 4.4-upgrade-gradle branch from d025014 to 01d5d00 Compare August 8, 2023 15:00
@ncordon ncordon mentioned this pull request Aug 8, 2023
Merged
@ncordon ncordon force-pushed the 4.4-upgrade-gradle branch from 01d5d00 to 2764976 Compare August 8, 2023 15:56
@ncordon ncordon force-pushed the 4.4-upgrade-gradle branch from feb79ad to d7c8c04 Compare August 9, 2023 09:51
@ncordon ncordon force-pushed the 4.4-upgrade-gradle branch from d7c8c04 to ce345ae Compare August 9, 2023 09:55
ncordon
ncordon commented Aug 9, 2023
View reviewed changes
full/build.gradle Outdated Show resolved Hide resolved
@ncordon ncordon mentioned this pull request Sep 14, 2023
Merged
@ncordon ncordon force-pushed the 4.4-upgrade-gradle branch from f036147 to 1298a74 Compare October 30, 2023 11:38
gem-neo4j
gem-neo4j approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@gem-neo4j gem-neo4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this looks reasonable to me! :D Thank you for doing this! Shall we update 5.x to 8.4 as well? 😁

@ncordon
Copy link
Contributor Author

ncordon commented Oct 31, 2023 •
edited
Loading

Shall we update 5.x to 8.4 as well? 😁

Yep, I'll take care. It should be easier than this one

@ncordon ncordon merged commit 2f9f739 into 4.4 Oct 31, 2023
11 checks passed
@ncordon ncordon deleted the 4.4-upgrade-gradle branch October 31, 2023 16:41
This was referenced Nov 6, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gem-neo4j gem-neo4j gem-neo4j approved these changes

Assignees

@gem-neo4j gem-neo4j

Labels
4.4 do_not_merge team-cypher-surface Cypher Surface team should review the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncordon @gem-neo4j