Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNKBKte1] Redacts passwords in CypherInitializer #3572

Merged
merged 1 commit into from
May 16, 2023
Merged

[UNKBKte1] Redacts passwords in CypherInitializer #3572

merged 1 commit into from
May 16, 2023

Conversation

ncordon
Copy link
Contributor

@ncordon ncordon commented May 11, 2023

What

We should obfuscate passwords when logging information in CypherInitializer

Why

Because if we used:

apoc.initializer.system.1=CREATE USER dummy IF NOT EXISTS SET PASSWORD pass12345

we were getting an entry in neo4j.log with the password in plaintext:

INFO  [system/00000000] successfully initialized: alter user neo4j SET PASSWORD "pass12345" CHANGE NOT REQUIRED

Expected behaviour

We should get a redacted password instead:

INFO  [system/00000000] successfully initialized: alter user neo4j SET PASSWORD "*****" CHANGE NOT REQUIRED

@ncordon ncordon force-pushed the 4.4-redacts-initializer-queries branch from 76dac42 to 8695619 Compare May 11, 2023 16:59
@ncordon ncordon added 4.4 team-cypher-surface Cypher Surface team should review the PR labels May 11, 2023
@ncordon ncordon added the bug label May 11, 2023
@ncordon ncordon added the to-cherry-pick issues related to commits to cherry-pick label May 12, 2023
pontusmelke
pontusmelke approved these changes May 15, 2023
View reviewed changes
Copy link

@pontusmelke pontusmelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

nadja-muller
nadja-muller approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@nadja-muller nadja-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@ncordon ncordon merged commit 18aaf50 into 4.4 May 16, 2023
@ncordon ncordon deleted the 4.4-redacts-initializer-queries branch May 16, 2023 08:04
@ncordon ncordon mentioned this pull request May 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadja-muller nadja-muller nadja-muller approved these changes

@pontusmelke pontusmelke pontusmelke approved these changes

Assignees

@nadja-muller nadja-muller

Labels
4.4 bug team-cypher-surface Cypher Surface team should review the PR to-cherry-pick issues related to commits to cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncordon @pontusmelke @nadja-muller