Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NOID] fixes #3477: apoc.load.html does not always report href #3478

Merged
merged 1 commit into from
Mar 27, 2023
Merged

[NOID] fixes #3477: apoc.load.html does not always report href #3478

merged 1 commit into from
Mar 27, 2023

Conversation

conker84
Copy link
Collaborator

Fixes #3477

If the baseUrl is not defined href is not returned.

Proposed Changes (Mandatory)

A brief list of proposed changes in order to fix the issue:

  • Fixed the bug
  • Added test

@conker84 conker84 changed the title fixes #3477: apoc.load.html does not always report href [NOID] fixes #3477: apoc.load.html does not always report href Feb 28, 2023
@conker84 conker84 requested a review from Lojjs February 28, 2023 16:34
jexp
jexp approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@jexp jexp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, perhaps we can replace the external web request in the test with a short html fragment that has the same structure?

@conker84
Copy link
Collaborator Author

conker84 commented Mar 1, 2023

Looks good to me, perhaps we can replace the external web request in the test with a short html fragment that has the same structure?

Sure lemme do that

@conker84 conker84 merged commit fdcc1e5 into neo4j-contrib:4.4 Mar 27, 2023
vga91 pushed a commit that referenced this pull request Mar 28, 2023
@conker84 @vga91
[NOID] fixes #3477: apoc.load.html does not always report href (#3478)
e1eadd4
vga91 pushed a commit that referenced this pull request Mar 28, 2023
@conker84 @vga91
[NOID] fixes #3477: apoc.load.html does not always report href (#3478)
7b176ed
vga91 added a commit that referenced this pull request Mar 28, 2023
@vga91 @conker84
[NOID] fixes #3477: apoc.load.html does not always report href (#3478) (
7b4e3bb 
#3506)

Co-authored-by: Andrea Santurbano <[email protected]>
vga91 added a commit that referenced this pull request Mar 28, 2023
@vga91 @conker84
[NOID] fixes #3477: apoc.load.html does not always report href (#3478) (
0916822 
#3505)

Co-authored-by: Andrea Santurbano <[email protected]>
vga91 added a commit that referenced this pull request Apr 28, 2023
@vga91 @conker84
[NOID] fixes #3477: apoc.load.html does not always report href (#3478) (
3d6f4e5 
#3505)

Co-authored-by: Andrea Santurbano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jexp jexp jexp approved these changes

@Lojjs Lojjs Awaiting requested review from Lojjs

Assignees
No one assigned
Labels
extended-functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@conker84 @jexp @vga91