Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2015: Various bugs with Neo4j 4.3 indexes #2262

Merged
merged 2 commits into from
Nov 10, 2021

Conversation

vga91
Copy link
Collaborator

@vga91 vga91 commented Oct 25, 2021

Fixes #2015

  • Implemented getIndexes(RelationshipType type) in SubGraph.java
  • Added relIndexes in Meta.java
  • Added lookup index handling

@Override
public Iterable<IndexDefinition> getIndexes(RelationshipType type) {
return indexes.stream()
.filter(idx -> StreamSupport.stream(idx.getRelationshipTypes().spliterator(), false).anyMatch(lb -> lb.equals(type)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably do equals on the name() to be sure, because RelationshipType is an interface so there is no symmetric equals

Copy link
Member

@jexp jexp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! Thanks a lot

@conker84 conker84 merged commit 64a054a into neo4j-contrib:4.3 Nov 10, 2021
JMHReif added a commit that referenced this pull request Jan 13, 2022
Co-authored-by: Giuseppe Villani <[email protected]>
Co-authored-by: Jennifer Reif <[email protected]>
vga91 added a commit to vga91/neo4j-apoc-procedures that referenced this pull request Feb 21, 2022
vga91 added a commit to vga91/neo4j-apoc-procedures that referenced this pull request Feb 24, 2022
vga91 added a commit to vga91/neo4j-apoc-procedures that referenced this pull request Mar 17, 2022
vga91 added a commit to vga91/neo4j-apoc-procedures that referenced this pull request Mar 23, 2022
vga91 added a commit to vga91/neo4j-apoc-procedures that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Various bugs with Neo4j 4.3 indexes
3 participants