-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2015: Various bugs with Neo4j 4.3 indexes #2262
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jexp
reviewed
Nov 10, 2021
@Override | ||
public Iterable<IndexDefinition> getIndexes(RelationshipType type) { | ||
return indexes.stream() | ||
.filter(idx -> StreamSupport.stream(idx.getRelationshipTypes().spliterator(), false).anyMatch(lb -> lb.equals(type))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should probably do equals on the name() to be sure, because RelationshipType is an interface so there is no symmetric equals
jexp
approved these changes
Nov 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR! Thanks a lot
conker84
pushed a commit
that referenced
this pull request
Dec 3, 2021
conker84
pushed a commit
that referenced
this pull request
Dec 7, 2021
JMHReif
added a commit
that referenced
this pull request
Jan 13, 2022
Co-authored-by: Giuseppe Villani <[email protected]> Co-authored-by: Jennifer Reif <[email protected]>
vga91
added a commit
to vga91/neo4j-apoc-procedures
that referenced
this pull request
Feb 21, 2022
vga91
added a commit
to vga91/neo4j-apoc-procedures
that referenced
this pull request
Feb 24, 2022
vga91
added a commit
to vga91/neo4j-apoc-procedures
that referenced
this pull request
Mar 17, 2022
vga91
added a commit
to vga91/neo4j-apoc-procedures
that referenced
this pull request
Mar 23, 2022
vga91
added a commit
to vga91/neo4j-apoc-procedures
that referenced
this pull request
Mar 29, 2022
conker84
pushed a commit
that referenced
this pull request
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2015
getIndexes(RelationshipType type)
inSubGraph.java
relIndexes
inMeta.java