Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEP: NeoContract Manifest #114

Merged
merged 22 commits into from
Jul 29, 2021
Merged

NEP: NeoContract Manifest #114

merged 22 commits into from
Jul 29, 2021

Conversation

bettybao1209
Copy link
Contributor

close #110

@bettybao1209 bettybao1209 marked this pull request as ready for review March 20, 2020 10:27
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a fine piece of art! Well written and described.
Thanks for the consideration and inclusion as author,

@shargon
Copy link
Member

shargon commented Mar 20, 2020

Thanks for my inclusion @bettybao1209 ! I think that the document describe well the manifest format. Good work!

@igormcoelho
Copy link

I'm honored for the inclusion, thanks!

nep-14.mediawiki Outdated Show resolved Hide resolved
nep-14.mediawiki Outdated Show resolved Hide resolved
@erikzhang
Copy link
Member

Merge?

@erikzhang
Copy link
Member

It should be merged after #119.

@shargon
Copy link
Member

shargon commented Mar 25, 2020

How will now the user that NEP3 and NEP6 it's obsolete? we should add a line for redirect to the new one

@erikzhang erikzhang changed the title NEP14: NeoContract Manifest NEP: NeoContract Manifest Mar 27, 2020
shargon
shargon previously approved these changes Jul 9, 2020
@luc10921
Copy link

luc10921 commented Dec 1, 2020

#2060 removed features and #2024 added name, but NEP-15 did not change it Specification to address those changes. Also, #2044 removed hash from ABI.

@gsmachado
Copy link

I was discussing With devhawk in this issue the need of specifying the file name suffix .manifest.json as a standard, to our community.

What I observe is that compilers give the option to developers to specify any kind of file name they want (which is not bad!), but then, at least the default output filename name should be set with a standardized suffix (i.e., .manifest.json).

This gains even more importance to developer experience if we consider that key tools in our community, like https://github.com/ngdenterprise/neo3-visual-tracker, relies on discovering contracts to be deployed based on the manifest filename.

I suggest adding, somewhere in this NEP:

The default filename suffix that compilers and tools should output is .manifest.json.

or something in this direction.

@erikzhang
Copy link
Member

erikzhang commented Apr 17, 2021

Does anyone have any comments or suggestions? @neo-project/everyone

shargon
shargon previously approved these changes Apr 17, 2021
shargon
shargon previously approved these changes Apr 19, 2021
@erikzhang erikzhang merged commit aee4f50 into neo-project:master Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add NEP14: Contract Manifest Standard
7 participants