Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Neo Core StdLib] Add Base64url #3453

Merged
merged 8 commits into from
Aug 8, 2024
Merged

[Neo Core StdLib] Add Base64url #3453

merged 8 commits into from
Aug 8, 2024

Conversation

Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Aug 7, 2024 •
edited
Loading

Description

This pr answers #3451 and adds base64url support.

Fixes # #3451

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • TestBase64Url

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Jim8y Jim8y marked this pull request as draft August 7, 2024 16:21
@Jim8y Jim8y mentioned this pull request Aug 7, 2024
Draft
10 tasks
@Jim8y Jim8y changed the base branch from master to HF_Echidna August 7, 2024 16:29
@Jim8y Jim8y marked this pull request as ready for review August 7, 2024 16:43
AnnaShaleva
AnnaShaleva reviewed Aug 7, 2024
View reviewed changes
src/Neo/SmartContract/Native/StdLib.cs Outdated Show resolved Hide resolved
src/Neo/SmartContract/Native/StdLib.cs Outdated Show resolved Hide resolved
@shargon shargon merged commit 9d16c53 into neo-project:HF_Echidna Aug 8, 2024
3 of 6 checks passed
@Jim8y Jim8y deleted the base64url branch August 8, 2024 20:39
@roman-khimov roman-khimov mentioned this pull request Aug 9, 2024
Open
Jim8y added a commit that referenced this pull request Oct 2, 2024
@Jim8y
[Neo Core StdLib] Add Base64url (#3453)
3fc8077 
* add base64url

* active in

* update placehold hf height

* fix hf issue and move methods to proper place.

* fix test

* use identifymodel instead.
Jim8y added a commit that referenced this pull request Nov 6, 2024
@Jim8y
[Neo Core StdLib] Add Base64url (#3453)
37bf0cb 
* add base64url

* active in

* update placehold hf height

* fix hf issue and move methods to proper place.

* fix test

* use identifymodel instead.
Jim8y added a commit that referenced this pull request Nov 17, 2024
@Jim8y
[Neo Core StdLib] Add Base64url (#3453)
fb08014 
* add base64url

* active in

* update placehold hf height

* fix hf issue and move methods to proper place.

* fix test

* use identifymodel instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnaShaleva AnnaShaleva AnnaShaleva left review comments

@cschuchardt88 cschuchardt88 cschuchardt88 approved these changes

@shargon shargon shargon approved these changes

Assignees
No one assigned
Labels
Hardfork Waiting for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jim8y @shargon @cschuchardt88 @AnnaShaleva