Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Move] Part-8 Classes into Different Library - Neo.Extensions #3447

Merged
merged 38 commits into from
Dec 2, 2024

Conversation

cschuchardt88
Copy link
Member

Description

Reorganized and move classes from neo library to neo.extensions library.

Fixed problems and warnings that occurred. Along with naming violations.

Change Log

  • Moved methods from Neo.VM.Helper class
  • Added EvaluationStackExtensions and UInt160Extensions class
  • Added using statement
  • Fixed unit tests

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit Testing

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

cschuchardt88 and others added 30 commits July 2, 2024 04:46
…`, `AssemblyExtensions`, `StringExtensdions`

Deleted `Helper.cs` file
@cschuchardt88 cschuchardt88 requested review from Jim8y and shargon August 4, 2024 22:23
@cschuchardt88 cschuchardt88 added the Blocked This issue can't be worked at the moment label Aug 4, 2024
@cschuchardt88 cschuchardt88 added Blocker Issues that are blocking other issues. Check issues details to see what it is blocking. Waiting for Review and removed Blocked This issue can't be worked at the moment labels Nov 29, 2024
@shargon shargon merged commit 79554f2 into neo-project:master Dec 2, 2024
6 checks passed
@cschuchardt88 cschuchardt88 deleted the rebuild/the-split-8 branch December 3, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker Issues that are blocking other issues. Check issues details to see what it is blocking. Ready to Merge Waiting for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants