Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment for jumptable #3187

Merged
merged 8 commits into from
Apr 2, 2024
Merged

Conversation

chenzhitong
Copy link
Member

No description provided.

@chenzhitong chenzhitong marked this pull request as ready for review March 29, 2024 07:34
@Jim8y
Copy link
Contributor

Jim8y commented Mar 29, 2024

@chenzhitong can you also add the satck change to the comments? like pop two, push one?

Copy link
Member

@cschuchardt88 cschuchardt88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You to change all method names to have a Prefix of Push or Pop or Add or Remove. So we can tell what's going on.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add CompareTo method.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pr only focus on adding comments to existing codes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add CompareTo method.

Focus on the changes in the pull request.

src/Neo.VM/JumpTable/JumpTable.Compound.cs Show resolved Hide resolved
src/Neo.VM/JumpTable/JumpTable.Compound.cs Show resolved Hide resolved
src/Neo.VM/JumpTable/JumpTable.Compound.cs Show resolved Hide resolved
src/Neo.VM/JumpTable/JumpTable.Compound.cs Show resolved Hide resolved
@chenzhitong
Copy link
Member Author

@chenzhitong can you also add the satck change to the comments? like pop two, push one?

OK

@shargon
Copy link
Member

shargon commented Apr 2, 2024

You to change all method names to have a Prefix of Push or Pop or Add or Remove. So we can tell what's going on.

Review not related to the PR. I will merge it.

@shargon shargon merged commit 183fd9f into neo-project:master Apr 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants