Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[neo-cli]: Plugin(s) Download Config File & Bug Fixes & Output Formatting #3092

Merged
merged 18 commits into from
Feb 1, 2024

Conversation

cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Jan 14, 2024

Change Log

  • Fixed Bugs (with tons of stuff)
  • Fixed Console Output Formatting
  • Rewrote DownloadPluginAsync Method
  • Added Configuration of Plugin Download URL
  • Edit Config JSON Files

Configuration Section

"Plugins": {
  "DownloadUrl": "https://api.github.com/repos/neo-project/neo-modules/releases",
  "Prerelease": false, // optional
  "Version": "3.6.3" // optional
}

Formatting Fix

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested Locally

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cschuchardt88 cschuchardt88 changed the title [neo-cli]: Plugins Downloads Config File & Bug Fixes & Output Formatting [neo-cli]: Plugin(s) Download Config File & Bug Fixes & Output Formatting Jan 14, 2024
Jim8y
Jim8y previously approved these changes Jan 14, 2024
Jim8y
Jim8y previously approved these changes Jan 14, 2024
@cschuchardt88
Copy link
Member Author

Had to fix some stuff that annoyed me.

Jim8y
Jim8y previously approved these changes Jan 15, 2024
@cschuchardt88
Copy link
Member Author

@shargon ???? You there?

@Jim8y
Copy link
Contributor

Jim8y commented Jan 26, 2024

Wait a minute, i am confused here, isn't the version thing still align with our old logic? the version is based on the executing assembly file? For me, this plugins still works the same, only added the plugins url to the config.

The version is not in the config, but can be parsed if added.....

@shargon
Copy link
Member

shargon commented Jan 26, 2024

Wait a minute, i am confused here, isn't the version thing still align with our old logic? the version is based on the executing assembly file? For me, this plugins still works the same, only added the plugins url to the config.

The version is not in the config, but can be parsed if added.....

This pr allows to install old plugins version with the current node

@Jim8y
Copy link
Contributor

Jim8y commented Jan 26, 2024

@shargon @cschuchardt88 how about make it #Debug only? such that the released version will not have this feature but developes can still use it to test.

@cschuchardt88
Copy link
Member Author

@shargon Now we ONLY load the version and prerelease when the build is Debug.

Jim8y
Jim8y previously approved these changes Jan 31, 2024
@shargon shargon merged commit 7c59fe8 into neo-project:master Feb 1, 2024
2 checks passed
@shargon shargon deleted the add-plugin-config branch February 1, 2024 11:00
@roman-khimov roman-khimov added this to the v3.7.0 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants