Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct typos, comments #2785

Merged
merged 10 commits into from
Jul 10, 2022
Merged

correct typos, comments #2785

merged 10 commits into from
Jul 10, 2022

Conversation

Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Jul 3, 2022

This pr does no update to the existing functions, but some minor correction to the typo, comments, and code style.

I admit that I have a bad habit to change the existing code style~~~~~

Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to avoid the linq changes

src/neo/Helper.cs Outdated Show resolved Hide resolved
@Jim8y
Copy link
Contributor Author

Jim8y commented Jul 3, 2022

I prefer to avoid the linq changes

Oh my, did not know linq is slower. Thank you, will revert changes on those.

src/neo/IO/ByteArrayEqualityComparer.cs Outdated Show resolved Hide resolved
src/neo/IO/Caching/HashSetCache.cs Outdated Show resolved Hide resolved
src/neo/Network/P2P/Payloads/GetBlockByIndexPayload.cs Outdated Show resolved Hide resolved
@devhawk
Copy link
Contributor

devhawk commented Jul 8, 2022

If we're going to do a PR like this, can we also update the year in the copyright statement? Some files specify Copyright (C) 2015-2021 and others specify Copyright (C) 2015-2022

Also, The neo is a little awkward. Maybe The neo project or The neo assembly?

@Jim8y
Copy link
Contributor Author

Jim8y commented Jul 9, 2022

Well, change from 2021 to 2022 just need a global replace, the question here is, do we need to do so. Since its MIT license, doing it or not does not matter at all.

@erikzhang @shargon How do you think about it? update 2022 to all files?

@shargon shargon merged commit e55325c into neo-project:master Jul 10, 2022
@Jim8y Jim8y deleted the typo-comment branch September 23, 2022 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants