Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEP10 inside ContractManifest.Abi #779

Closed
shargon opened this issue May 24, 2019 · 15 comments · Fixed by #1729
Closed

NEP10 inside ContractManifest.Abi #779

shargon opened this issue May 24, 2019 · 15 comments · Fixed by #1729
Labels
Design Issue state - Feature accepted but the solution requires a design before being implemented Enhancement Type - Changes that may affect performance, usability or add new features to existing modules. VM New features that affect the Neo Virtual Machine or the Interop layer

Comments

@shargon
Copy link
Member

shargon commented May 24, 2019

The proposal is simple, I think that we can move the logic of supportedStandards to Contract Manifest, more concretely, inside the Abi
@erikzhang erikzhang added the Discussion Initial issue state - proposed but not yet accepted label May 24, 2019
@vncoelho
Copy link
Member

I agree, @shargon.

@igormcoelho
Copy link
Contributor

I agree @shargon, as long as other contracts could onchain access a contractabi (GetContract hash + GetContractAbi).

@erikzhang
Copy link
Member

Didn't understand.

@shargon
Copy link
Member Author

shargon commented May 25, 2019 •
edited
Loading

I think that should be good if we add supportedStandards method inside Abi properties

@erikzhang
Copy link
Member

You can read ABI, but it's hard for a contract to analyze the JSON file to get the supportedStandards.

@igormcoelho
Copy link
Contributor

ABI and JSON could be InteropInterface, so they have simple methods to access information... also serialization and deserialization.

@erikzhang
Copy link
Member

We need JSON API in smart contract.

@shargon shargon mentioned this issue May 26, 2019
Merged
@lock9 lock9 added Design Issue state - Feature accepted but the solution requires a design before being implemented Enhancement Type - Changes that may affect performance, usability or add new features to existing modules. VM New features that affect the Neo Virtual Machine or the Interop layer and removed Discussion Initial issue state - proposed but not yet accepted labels Aug 11, 2019
@shargon
Copy link
Member Author

shargon commented Sep 12, 2019

Now we have the json API, time to revive this issue?

@lock9
Copy link
Contributor

lock9 commented Sep 13, 2019

@shargon agreed.
@neo-project/core what is your opinion?

@shargon
Copy link
Member Author

shargon commented Jan 13, 2020

It's ready to implement?

Thacryba pushed a commit to simplitech/neo that referenced this issue Feb 17, 2020
@ixje @fabwa
Update neo-cli OSX installation instructions (neo-project#779)
ffd4faa
@Tommo-L
Copy link
Contributor

Tommo-L commented Jun 24, 2020

@shargon ping?

@shargon shargon mentioned this issue Jun 24, 2020
Merged
@shargon
Copy link
Member Author

shargon commented Jun 24, 2020

Can someone help me amending https://github.com/neo-project/proposals/blob/master/nep-10.mediawiki ?

@Tommo-L
Copy link
Contributor

Tommo-L commented Jun 24, 2020

Both nep-10 and nep-14?

@shargon
Copy link
Member Author

shargon commented Jun 24, 2020

Yes

@Tommo-L
Copy link
Contributor

Tommo-L commented Jun 28, 2020

We'll update them this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Design Issue state - Feature accepted but the solution requires a design before being implemented Enhancement Type - Changes that may affect performance, usability or add new features to existing modules. VM New features that affect the Neo Virtual Machine or the Interop layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move NEP10 to manifest shargon/neo
6 participants
@igormcoelho @shargon @erikzhang @vncoelho @lock9 @Tommo-L