Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strange logic about the default seed node #2772

Closed
RichardBelsum opened this issue Jun 15, 2022 · 4 comments · Fixed by #2980
Closed

Strange logic about the default seed node #2772

RichardBelsum opened this issue Jun 15, 2022 · 4 comments · Fixed by #2980
Milestone
v3.7.0

Comments

@RichardBelsum
Copy link

When I built the private net, I removed the SeedList from config.json and it still connects to the seed node on startup

image

image
@satoshichou satoshichou mentioned this issue Jun 15, 2022
Closed
@shargon
Copy link
Member

shargon commented Jun 15, 2022

If it's empty it will take the defaults one

@erikzhang
Copy link
Member

If you remove SeedList, it will take the default ones. But if you pass an empty array [], the seed list will be empty.

@ixje
Copy link
Contributor

ixje commented Jun 22, 2022

If you remove SeedList, it will take the default ones. But if you pass an empty array [], the seed list will be empty.

That's not how it really works

Screen.Recording.2022-06-22.at.08.37.00.mov

@shargon
Copy link
Member

shargon commented Jun 22, 2022 •
edited
Loading

It seems that empty array returns false in section.Exists()...

dotnet/extensions#1341 (works as designed)

@ixje ixje mentioned this issue Jul 5, 2022
Closed
@roman-khimov roman-khimov mentioned this issue Sep 14, 2023
Closed
shargon added a commit that referenced this issue Nov 21, 2023
@shargon
Remove unnecessary default seedlist
df8b191 
Close #2772
@shargon shargon mentioned this issue Nov 21, 2023
Merged
@roman-khimov roman-khimov added this to the v3.7.0 milestone Nov 21, 2023
shargon added a commit that referenced this issue Nov 25, 2023
@shargon @Jim8y @vncoelho
Remove unnecessary default seedlist (#2980)
683af79 
* Remove unnecessary default seedlist

Close #2772

* fix ut

* Update TestProtocolSettings.cs

* use existing default setting for test setting.

* add ut-test cases

* add test to ut setting.load

* Update TestBlockchain.cs

* Apply suggestions from code review

* Update tests/Neo.UnitTests/UT_ProtocolSettings.cs

* Update tests/Neo.UnitTests/TestProtocolSettings.cs

* Fix some UT

---------

Co-authored-by: Jinghui Liao <[email protected]>
Co-authored-by: Vitor Nazário Coelho <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.7.0
5 participants
@shargon @ixje @erikzhang @roman-khimov @RichardBelsum