Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classes related to Neo.SmartContract types should not be internal #1782

Closed
devhawk opened this issue Jul 21, 2020 · 0 comments
Closed

Classes related to Neo.SmartContract types should not be internal #1782

devhawk opened this issue Jul 21, 2020 · 0 comments
Labels
Discussion Initial issue state - proposed but not yet accepted

Comments

@devhawk
Copy link
Contributor

devhawk commented Jul 21, 2020

Since we decided to implement IApplicationEngineProvider (#1758), there is a use case for subclassing ApplicationEngine. Types like InteropDescription and methods like Convert should be marked public so they can be used in subclasses
@devhawk devhawk added the Discussion Initial issue state - proposed but not yet accepted label Jul 21, 2020
This was referenced Jul 21, 2020
Closed
Merged
shargon added a commit that referenced this issue Jul 22, 2020
@devhawk @shargon
Classes related to Neo.SmartContract types should not be internal (#1785
54a1094 
)

* Classes related to Neo.SmartContract types should not be internal
Fixes #1782

* public callbacks + protected internal service methods

* Add AsReadOnly()

Co-authored-by: Harry Pierson <[email protected]>
Co-authored-by: Shargon <[email protected]>
cloud8little pushed a commit to cloud8little/neo that referenced this issue Jan 24, 2021
@erikzhang @devhawk
@shargon @Tommo-L @cloud8little
Preview3 (neo-project#1820)
b7c0b76 
* Classes related to Neo.SmartContract types should not be internal (neo-project#1785)

* Classes related to Neo.SmartContract types should not be internal
Fixes neo-project#1782

* public callbacks + protected internal service methods

* Add AsReadOnly()

Co-authored-by: Harry Pierson <[email protected]>
Co-authored-by: Shargon <[email protected]>

* Add AppEngine.ValidateCallFlags to be callable by subclasses (neo-project#1784)

* Update ApplicationEngine.cs

separate call flag validation into separate function so it can be called by ApplicationEngine subclasses. This is needed for the debugger, which overrides a few of the standard service implementations

* fix whitespace

* protected internal addGas

Co-authored-by: Harry Pierson <[email protected]>

* Fix vote (neo-project#1792)

* fix vote

* add ut

* throw exception

* fix

* fix ut

Co-authored-by: Tommo-L <[email protected]>
Co-authored-by: erikzhang <[email protected]>

* preview3

* Update dependency

Co-authored-by: Harry Pierson <[email protected]>
Co-authored-by: Harry Pierson <[email protected]>
Co-authored-by: Shargon <[email protected]>
Co-authored-by: Luchuan <[email protected]>
Co-authored-by: Tommo-L <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Discussion Initial issue state - proposed but not yet accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Classes related to Neo.SmartContract types should not be internal
1 participant
@devhawk