Skip to content

Commit

Permalink
Adding suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
lock9 committed Aug 14, 2019
1 parent 5bcb318 commit 9e558fb
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ The issue list is reserved exclusively for bug reports and features discussions.
### dApp Development
This document does not relate to dApp development. If you are looking to build a dApp using Neo, please [start here](https://neo.org/dev).

### Contributing to open source projects
If you are new to open-source development, please [read here](https://opensource.guide/how-to-contribute/#opening-a-pull-request) how to submit your code.

## Developer Guidance
We try to have as few rules as possible, just enough to keep the project organized:

Expand All @@ -20,6 +23,8 @@ We try to have as few rules as possible, just enough to keep the project organi
Avoid implementing issues with the discussion tag.
2. **Tests during code review**. We expect reviewers to test the issue before approving or requesting changes.

3. **Wait for at least 2 reviews before merging**. Changes can be merged after 2 approvals, for Neo 3.x branch, and 3 approvals for Neo 2.x branch.

3. **Give time to other developers review an issue**. Even if the code has been approved, you should leave at least 24 hours for others to review it before merging the code.

4. **Create unit tests**. It is important that the developer includes basic unit tests so reviewers can test it.
Expand Down

0 comments on commit 9e558fb

Please sign in to comment.