Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using DisplayName for function name compatibility with ABI #25

Closed
wants to merge 2 commits into from

Conversation

igormcoelho
Copy link
Contributor

According to a discussion in neo-project/proposals#12, method names could use DisplayName to guarantee full compatibility with string name in ABI.

@igormcoelho
Copy link
Contributor Author

igormcoelho commented Jul 3, 2018

@RavenXce and @erikzhang, it seems the better option is to use DisplayName to adjust function names, so C# programmers can keep C# standard (starting upper case), while making everything 100% compatible with ABI signatures :)

@erikzhang
Copy link
Member

Maybe we should make the compiler automatically turn the first letter of the method name into lowercase when generating the ABI?
@lightszero

@igormcoelho
Copy link
Contributor Author

igormcoelho commented Jul 3, 2018

It's also easy to do... which direction is the best,I dont know hahaha

@igormcoelho
Copy link
Contributor Author

Now I believe the best option is to have Neon compiler generating ABI with first letter in lowercase. So this PR can be discarded. Anyway, until this change is not done, our example on neocompiler.io will use this fix (using DisplayName).

@igormcoelho
Copy link
Contributor Author

Nevermind, I'll simply use the same strategy for automatic capitalization at neocompiler-eco platform: NeoResearch/neocompiler-eco@f03ef9c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants