Fix importerror on pyqt5.sip #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #548 (comment)
What I first thought was wrong. It is simply a changed import in the latest pyqtgraph that requires a slightly newer pyqt5 than included with ubuntu 18.04.
And.... apparently than included in the LTR for windows, but I don't have access to such a machine right now.
Limiting pyqtgraph should do the trick.
But... why does "pip install --find-links" install a NEW pyqtgraph even though we bundle 0.11.1? I've checked our latest plugin.zip: it is in there.