Mention about addXxx() methods
#791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theofidry
reviewed
Sep 14, 2017
There was a problem hiding this comment.
That's a good point 👍
I think we could go slightly further and mention a couple of upgrade path here as well:
- Custom Hydrator with the appropriate link: https://github.com/nelmio/alice/blob/master/doc/advanced-guide.md#custom-accessor
- Add a setter which the default symfony property accessor will be able to pick
- Last but not least (and I think it's the best solution) is to rely on the new
__callsfeature: https://github.com/nelmio/alice/blob/master/doc/complete-reference.md#calling-methods
UPGRADE.md
Outdated
| } | ||
| ``` | ||
|
|
||
| See: https://github.com/nelmio/alice/issues/654 |
There was a problem hiding this comment.
I would make it a link: [See the original discussion](https://github.com/nelmio/alice/issues/654)
|
|
||
| ## User-land changes | ||
|
|
||
| - `addXxx()` methods are no longer supported, you need to define a setter for the collection. |
There was a problem hiding this comment.
Do you know if a deprecation is provided in 2.x for that? I would expect one, otherwise could be nice to add it.
|
Thanks again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
addXxx()methods are no longer supported in v3.0 and it is not mentioned in the BC changes.