Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework callers #734

Merged
merged 6 commits into from
May 17, 2017
Merged

Rework callers #734

merged 6 commits into from
May 17, 2017

Conversation

theofidry
Copy link
Member

@theofidry theofidry commented May 11, 2017 •
edited
Loading

The last big piece (#731) should be very easy after that one for the 3.0.0.

  • Add support for flags in methods, e.g. optional calls
  • Add an extension point for flag handling
  • Add support for static or service reference calls

Closes #732

LoaderIntegrationTest is passing but the rest needs more polishing:

  • Finish the code (there's some missing bits)
  • Add missing tests
  • Add doc
  • Cleanup

@theofidry theofidry changed the title Rework callers [WIP] Rework callers May 11, 2017
@theofidry theofidry mentioned this pull request May 14, 2017
Closed
@theofidry theofidry changed the title [WIP] Rework callers Rework callers May 16, 2017
@theofidry
Copy link
Member Author

@ogizanagi adding support for immutable functions should be trivial now.

ogizanagi
ogizanagi approved these changes May 17, 2017
View reviewed changes
Copy link
Contributor

@ogizanagi ogizanagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@theofidry theofidry merged commit d055e71 into nelmio:master May 17, 2017
@theofidry theofidry deleted the feature/caller branch May 17, 2017 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogizanagi ogizanagi ogizanagi approved these changes

Assignees
No one assigned
Labels
Needs work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theofidry @ogizanagi