Add the factory keyword #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ogizanagi would you mind doing a quick review on that one? |
ogizanagi
approved these changes
May 9, 2017
| @@ -64,6 +66,24 @@ public function denormalize(FixtureInterface $scope, FlagParserInterface $parser | |||
| if ('__construct' === $unparsedPropertyName) { | |||
| $constructor = $this->denormalizeConstructor($value, $scope, $parser); | |||
|
|
|||
| if (false === ($constructor instanceof NoMethodCall) && '__construct' !== $constructor->getMethod()) { | |||
There was a problem hiding this comment.
- if (false === ($constructor instanceof NoMethodCall) && '__construct' !== $constructor->getMethod()) {
+ if (!$constructor instanceof NoMethodCall && '__construct' !== $constructor->getMethod()) {?
There was a problem hiding this comment.
I kinda prefer being explicit instead of using !, as it's the current convention I would prefer not to change it at that point :)
| $this->assertSame($expected, $actual); | ||
| } | ||
|
|
||
| public function testDenormalizesConstructorWithTheDecoratedConstructorDenormalizerIfCannotDenormalizeWithTheFactoryDenormalizer() |
There was a problem hiding this comment.
I'm breathless and stuttering just by reading this in my head 😆
There was a problem hiding this comment.
yeah, I would like to switch to snake case as for php spec, this would already be somewhat more readable... but I don't have the will to update all the tests for that^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tackles the
__factorypart of #388.Todo:
__constructin favour of__factory__constructwith only 1 named param, it is not clear if the param is an argument key or a constructor name. In__factorythe ambiguity is non existent