Prepare for PHPUnit 6 #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After these changes the project is compatible with PHPUnit 6.0. The symfony/phpunit-bridge however is still not compatible, so the version requirement in the composer.json is not elevated to ^6.0 yet. As soon as symfony fixes their bridge this can be done.
theofidry
reviewed
Mar 22, 2017
| backupGlobals="false" | ||
| bootstrap="vendor/autoload.php" | ||
| colors="true" | ||
| enforceTimeLimit="true" | ||
| beStrictAboutTestsThatDoNotTestAnything="false" |
There was a problem hiding this comment.
Not yet, but in PHPUnit 6.0 you will get a lot of risky tests and exit code 1 when you have no explicit asserts in them. This maintains 5.x behaviour for now.
But since I did not update the constraint yet, it is not strictly necessary.
There was a problem hiding this comment.
I can remove it, with no problem, just let me know what is preferable.
There was a problem hiding this comment.
Ah I see it becomes strict by default in 6.0. Fine then :)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After these changes the project is compatible with PHPUnit 6.0.
The symfony/phpunit-bridge however is still not compatible, so
the version requirement in the composer.json is not elevated to
^6.0 yet. As soon as symfony fixes their bridge this can be done.