Support instanciation of object with named constructor #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,6 +22,10 @@ public function canInstantiate(Fixture $fixture) | |||
| { | |||
| $reflConstruct = new \ReflectionMethod($fixture->getClass(), '__construct'); | |||
|
|
|||
| if (!$reflConstruct->isPublic() && '__construct' !== $fixture->getConstructorMethod()) { | |||
There was a problem hiding this comment.
@gquemener Let's just add this conditional bit to the line below - it's effectively the same thing, but this makes it look like there's much more change happening than there actually is. Make sense?
|
Yes it does @tshelburne, I was concerned about readability issues with a long conditionnal statement but it's not so bad in the end. Tell me if you want me to squash the PR before merge. |
tshelburne
added a commit
that referenced
this pull request
Jan 7, 2016
Support instanciation of object with named constructor
|
@gquemener Thanks! |
|
Is it possible to tag a 2.1.4 with this fix please @tshelburne? |
|
@gquemener Bam! Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently having a private constructor will force instanciation using reflection (using instanciator
ReflectionWithoutConstructor).Current implementation only allows to use factory method when the class constructor is public.
This is not working when using the Named constructors (http://verraes.net/2014/06/named-constructors-in-php/)
This PR intends to provide the use case describing this scenario and open discussion about the best way to handle it.
So far, I've tried to manipulate the
ReflectionWithConstructorandReflectionWithoutConstructorcanInstantiatemethod, but I can't make the whole test suite pass.