Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quote to yaml reserved chars in fixtures. #290

Merged
merged 1 commit into from
Nov 26, 2015
Merged

Add quote to yaml reserved chars in fixtures. #290

merged 1 commit into from
Nov 26, 2015

Conversation

akerouanton
Copy link

No description provided.

@Seldaek
Copy link
Member

Seldaek commented Nov 16, 2015

Would you mind updating the markdown files of the docs too? We shouldn't promote stuff that won't work..

@akerouanton
Copy link
Author

@Seldaek done ;)

@soullivaneuh
Copy link
Contributor

@NiR- since when using @thing directly cause problems with yaml? Don't have this issue on my projects.

@jenkoian
Copy link
Contributor

@soullivaneuh it's to work with Symfony 3 due to symfony/symfony#16285

@soullivaneuh
Copy link
Contributor

Oh I see, thanks for the tip. 👍

```

Alice also allows you to directly reference objects' properties using the ```@name->property``` notation.
Alice also allows you to directly reference objects' properties using the ```'@name->property'``` notation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but those at line 7, 35 and here should not be quoted IMO, as they are not in the Yaml. The quotes aren't part of the alice syntax.

@Einenlum
Copy link
Contributor

Up ?

Seldaek added a commit that referenced this pull request Nov 26, 2015
Add quote to yaml reserved chars in fixtures.
@Seldaek Seldaek merged commit d0bdaee into nelmio:master Nov 26, 2015
@Seldaek
Copy link
Member

Seldaek commented Nov 26, 2015

Thanks

@akerouanton akerouanton deleted the fix/sf3-tests branch November 26, 2015 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants