Allow this component to work with symfony3 #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - php: 5.6 | ||
| env: DEPS=dev | ||
| - php: 5.6 | ||
| env: DEPS=dev SYMFONY_VERSION='2.8.*' |
There was a problem hiding this comment.
2.8.*@dev would be better than a DEPS option IMO.
|
@Seldaek It's been a bit since I dealt with Symfony and PHP - does this all look good to you? |
|
Seems fine yeah, we barely use any symfony anyway. One issue though is that AFAIK symfony3's yaml component doesn't allow unquoted |
Seldaek
added a commit
that referenced
this pull request
Nov 9, 2015
Allow this component to work with symfony3
|
Symfony 3.0 is now released. Did you plan a date for a new tag of this bundle? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.