Fix a few issues (#740)

nelmio · May 21, 2017 · 32d327e · 32d327e
1 parent 26691c0
commit 32d327e
Show file tree

Hide file tree

Showing 7 changed files with 18 additions and 50 deletions.
diff --git a/...ures/FixtureBuilder/Denormalizer/Fixture/Chainable/DummyAbstractChainableDenormalizer.php b/...ures/FixtureBuilder/Denormalizer/Fixture/Chainable/DummyAbstractChainableDenormalizer.php
diff --git a/humbug.json.dist b/humbug.json.dist
@@ -5,17 +5,17 @@
         ],
         "excludes": [
             "fixtures",
+            "src/deep_clone.php",
             "src/Bridge",
             "src/FileLocator/DefaultFileLocator.php",
             "src/FixtureBuilder/Denormalizer/Fixture/Chainable/RangeNameDenormalizer.php",
-            "src/functions.php",
             "src/Generator/Resolver/Parameter/Chainable/RecursiveParameterResolver.php",
             "tests",
             "vendor"
         ]
     },
     "timeout": 10,
     "logs": {
-        "text": "humbuglog.txt"
+        "text": "dist/humbuglog.txt"
     }
 }
diff --git a/phpstan.neon b/phpstan.neon
@@ -0,0 +1,10 @@
+parameters:
+    excludes_analyse:
+        - %rootDir%/../../../../../fixtures/Bridge
+        - %rootDir%/../../../../../src/Bridge
+    ignoreErrors:
+        # Prophecy
+        - '#Call to an undefined method Prophecy\\Prophecy\\ObjectProphecy::[a-zA-Z0-9_]+\(\)#'
+        - '#Access to an undefined property Prophecy\\Prophecy\\ObjectProphecy::\$[a-zA-Z0-9_]+#'
+
+        # False positives
diff --git a/src/Definition/Value/DynamicArrayValue.php b/src/Definition/Value/DynamicArrayValue.php
@@ -23,7 +23,7 @@
 final class DynamicArrayValue implements ValueInterface
 {
     /**
-     * @var string|ValueInterface
+     * @var int|ValueInterface
      */
     private $quantifier;
 

diff --git a/src/Definition/Value/OptionalValue.php b/src/Definition/Value/OptionalValue.php
@@ -22,7 +22,7 @@
 final class OptionalValue implements ValueInterface
 {
     /**
-     * @var string|ValueInterface
+     * @var int|ValueInterface
      */
     private $quantifier;
 
@@ -37,7 +37,7 @@ final class OptionalValue implements ValueInterface
     private $secondMember;
 
     /**
-     * @param int|ValueInterface         $quantifier
+     * @param int|string|ValueInterface         $quantifier
      * @param string|ValueInterface      $firstMember
      * @param string|ValueInterface|null $secondMember
      */

diff --git a/...der/Denormalizer/Fixture/SpecificationBagDenormalizer/Constructor/FactoryDenormalizer.php b/...der/Denormalizer/Fixture/SpecificationBagDenormalizer/Constructor/FactoryDenormalizer.php
@@ -43,7 +43,7 @@ public function denormalize(
         FlagParserInterface $parser,
         array $unparsedMethod
     ): MethodCallInterface {
-        /** @var string $method */
+        /** @var string|bool $method */
         $method = key($unparsedMethod);
 
         if (false === $method

diff --git a/...alizer/Fixture/SpecificationBagDenormalizer/Constructor/LegacyConstructorDenormalizer.php b/...alizer/Fixture/SpecificationBagDenormalizer/Constructor/LegacyConstructorDenormalizer.php
@@ -25,12 +25,12 @@ final class LegacyConstructorDenormalizer implements ConstructorDenormalizerInte
     use IsAServiceTrait;
 
     /**
-     * @var ConstructorDenormalizer
+     * @var ConstructorDenormalizerInterface
      */
     private $constructorDenormalizer;
 
     /**
-     * @var ConstructorDenormalizer
+     * @var ConstructorDenormalizerInterface
      */
     private $factoryDenormalizer;