Fix compatibility with twig 3.9 and yielding #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdreesen
reviewed
Apr 22, 2024
franmomu
approved these changes
Jun 2, 2024
|
thanks @jderusse! |
Seldaek
reviewed
Jul 1, 2024
| ->subcompile($body) | ||
| ->write($output) | ||
| ; | ||
| $compiler->write("echo \$content;\n"); |
There was a problem hiding this comment.
I still get deprecation warnings in the test suite which I think are coming from this line?
4x: Since twig/twig 3.9: Using "echo" is deprecated, use "yield" instead in "Nelmio\SecurityBundle\Twig\Node\CSPNode", then flag the class with #[YieldReady].
2x in IntegrationTest::testItWorksDynamically from Nelmio\SecurityBundle\Tests\Twig
2x in IntegrationTest::testItWorksStatically from Nelmio\SecurityBundle\Tests\Twig
Should this not be a yield?
There was a problem hiding this comment.
indeed :(
fixed in #353
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes CSPNode compatible with twig 3.9.
Since twigphp/Twig#3999 we cannot use
ob_method to get the generated output (See twigphp/Twig#4034)This PR fixes the issue by using the CaptureNode introduced in twigphp/Twig#3954
Fix #343