Use jms/serializer groups detection logic #1482
Conversation
|
@GuilhemN If you are OK with moving that logic outside of nelmio-apidoc, I can complete this |
|
Indeed, it probably makes more sense to include this in JMS 👍 |
|
Great! will let you know as soon as i am done! |
goetas
force-pushed
the
use-jms-groups-logic
branch
from
907ebe9 to
5f911b7
Compare
goetas
force-pushed
the
use-jms-groups-logic
branch
2 times, most recently
from
3b7d81b to
af1fa58
Compare
goetas
force-pushed
the
use-jms-groups-logic
branch
from
af1fa58 to
f415ac2
Compare
|
@GuilhemN excluding the composer.json changes, this is ready for review (probably a first round). Preamble: I'm going to release jms/serializer 3.0, that reverts the nested group strategy as it was in 1.x (see schmittjoh/serializer#1071). 2.x will not be supported anymore. Because of the jms/serializer changes, I think also that naelmio/api-doc should just drop support for jms/serializer 2.x, and focus only on 1.x and 3.x. This decision allows to not have to maintain anymore v1 and v2 tests, so I have just deleted the v2 tests. Regarding the other changes, now jms/serializer exposes |
composer.json
Outdated
| @@ -44,7 +44,8 @@ | |||
| "api-platform/core": "^2.1.0", | |||
| "friendsofsymfony/rest-bundle": "^2.0", | |||
| "willdurand/hateoas-bundle": "^1.0|^2.0", | |||
| "jms/serializer-bundle": "^2.0|^3.0" | |||
| "jms/serializer-bundle": "^2.0|^3.0", | |||
| "jms/serializer": "dev-master as 2.99.0" | |||
There was a problem hiding this comment.
when this jms/serializer 3.0 will be tagged, this will be just ^1.14|^3.0
composer.json
Outdated
| @@ -29,7 +29,7 @@ | |||
| "symfony/asset": "^3.4|^4.0", | |||
| "symfony/console": "^3.4|^4.0", | |||
| "symfony/config": "^3.4|^4.0", | |||
| "symfony/validator": "^3.4|^4.0", | |||
| "symfony/validator": "^3.4|~4.1.0", | |||
There was a problem hiding this comment.
this is a temporary fix for symfony/symfony#31152
goetas
force-pushed
the
use-jms-groups-logic
branch
from
f415ac2 to
8dc283e
Compare
goetas
force-pushed
the
use-jms-groups-logic
branch
from
8dc283e to
4fbf096
Compare
goetas
changed the title
|
@GuilhemN this is ready! jms/serializer v3 released the test failure is related to symfony/symfony#31152 |
|
Great, thank you @goetas :) Congrats for releasing JMS v3 😃 |
This PR moves outside of NelmioApiDocBundle the logic for groups detection.
In this way jms/serializer can change the groups logic without affection NelmioApiDocBundle code.
Another advantage or this solution is that will be possible to introduce easily other exclusion strategies (as versioning) without changing too much code.
TODO: