-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Fossil dep type #31
base: master
Are you sure you want to change the base?
Conversation
Wow, thanks for looking into this! The tests failing seem unrelated to this change so I'll get those fixed up and then get this merged in. 😄 |
zigwin32 and hzzp are updated, still waiting on iguanatls |
Rebased this branch to master and looks all good to go. Do we have a fossil repo hosted anywhere with some Zig code we can use to verify the functionality doesn't regress going forward? |
this is mine: http://chiselapp.com/user/javier/repository/zigqlite |
Thanks! I'll give the repo a test and get this merged. Thanks again for pull this together :) For C libraries you can see an example here https://github.com/nektro/zig-sqlite3/blob/master/zig.mod as well as the |
One thing i'm noticing is that in the lockfile its always using the "commit" (in git speak). similarly, it makes me wonder if the fossil type should have equivalents for specifying "branch" or "tag" if those exist |
isn't the lockfile's purpose to "lock" the current version? the dependencies can use any way to specify a version (tag, branch, commit, or none), but the lockfile should use the exact commit... unless i'm missing something. |
ee413e0
to
0c363b8
Compare
0c363b8
to
98875eb
Compare
No longer assume `gpa` global allocator.
98875eb
to
e582f79
Compare
Sorry for letting this sit for so long. If a test is added, happy to merge this (if the branch is rebased there's CI and a regression test suite now) |
No description provided.