refactor: export and move shared contexts into pkg/model #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZauberNerd
force-pushed
the
move-shared-contexts
branch
from
9ccb081 to
ce531bf
Compare
This comment has been minimized.
This comment has been minimized.
ZauberNerd
force-pushed
the
move-shared-contexts
branch
from
ce531bf to
7764aa5
Compare
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #931 +/- ##
==========================================
+ Coverage 49.27% 56.98% +7.71%
==========================================
Files 23 29 +6
Lines 2401 4224 +1823
==========================================
+ Hits 1183 2407 +1224
- Misses 1090 1610 +520
- Partials 128 207 +79
Continue to review full report at Codecov.
|
ZauberNerd
force-pushed
the
move-shared-contexts
branch
from
7764aa5 to
381daba
Compare
|
@catthehacker if this PR is a change you'd be willing to merge before #908 then it is ready for review from our side. |
catthehacker
previously approved these changes
Dec 16, 2021
There was a problem hiding this comment.
I guess it looks ok, @cplee opinion on this will be more valuable
4 tasks
cplee
previously approved these changes
Dec 22, 2021
This comment has been minimized.
This comment has been minimized.
|
@ZauberNerd this pull request has failed checks 🛠 |
|
@ZauberNerd this pull request is now in conflict 😩 |
This commit moves the githubContext, jobContext and stepResult structs from the runner package to the model package in preparation for nektos#908 because the expression.go file lives in the runner package and would introduce cyclic dependencies with the exprparser package. Co-authored-by: Markus Wolf <[email protected]>
ZauberNerd
force-pushed
the
move-shared-contexts
branch
from
2c874ea to
6efaf9f
Compare
mergify
bot
removed
conflict
catthehacker
approved these changes
Dec 22, 2021
cplee
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves the
githubContext,jobContextandstepResultstructsfrom the
runnerpackage to themodelpackage in preparation for #908because the
expression.gofile lives in therunnerpackage and wouldintroduce cyclic dependencies with the
exprparserpackage.